Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts/ens: Add ENS contract binding #2952

Merged
merged 1 commit into from
Aug 29, 2016
Merged

contracts/ens: Add ENS contract binding #2952

merged 1 commit into from
Aug 29, 2016

Conversation

Arachnid
Copy link
Contributor

No description provided.

@robotally
Copy link

robotally commented Aug 26, 2016

Vote Count Reviewers
👍 0
👎 0
Reaction Users
:21: @fjl

Updated: Mon Aug 29 14:54:49 UTC 2016

@fjl
Copy link
Contributor

fjl commented Aug 26, 2016

contracts\ens\ens_test.go:21: github.com/ethereum/go-ethereum/core.GenesisAccount composite literal uses unkeyed fields

@Arachnid
Copy link
Contributor Author

@fjl done

@fjl
Copy link
Contributor

fjl commented Aug 26, 2016

Please add LGPL license headers to all files including the generated wrapper. Just copy from any file and make sure the year is 2016.

@Arachnid
Copy link
Contributor Author

PTAL.

@@ -1,5 +1,21 @@
//go:generate abigen --sol contract/ENS.sol --pkg contract --out contract/ens.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this line below the package declaration. I should've said that earlier, sorry.

@zelig zelig mentioned this pull request Aug 29, 2016
9 tasks
@Arachnid Arachnid force-pushed the ens branch 5 times, most recently from 913df57 to 70239ac Compare August 29, 2016 15:59
@fjl fjl merged commit 969008d into ethereum:develop Aug 29, 2016
@fjl fjl removed the review label Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants