accounts/keystore: add sleep back for TestUpdatedKeyfileContents#29508
Closed
darioush wants to merge 1 commit into
Closed
accounts/keystore: add sleep back for TestUpdatedKeyfileContents#29508darioush wants to merge 1 commit into
darioush wants to merge 1 commit into
Conversation
Contributor
|
Test was fixed in #29867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I understand that in #28461 these sleeps were replaced with
Chtimesto reduce test execution time.However, I noticed this test sometimes fails on linux with the race detector enabled, eg:
go test -timeout 900s github.com/ethereum/go-ethereum/accounts/keystore -cover -count=10 -race -shuffle=onI believe updating the mod time to a past time does not work due to the way the fileCache tracks
lastMod:go-ethereum/accounts/keystore/file_cache.go
Lines 71 to 77 in 9dcf8aa
The sleeps seem preferable to modifying the file cache for testing, or alternatively resetting the
lastModfield in the test. Thanks for your consideration.