Skip to content

fix(usbwallet): improve ledger support#28863

Closed
felipe-op wants to merge 1 commit intoethereum:masterfrom
felipe-op:felipe/ledger
Closed

fix(usbwallet): improve ledger support#28863
felipe-op wants to merge 1 commit intoethereum:masterfrom
felipe-op:felipe/ledger

Conversation

@felipe-op
Copy link
Copy Markdown

This change allows Ledger devices to be found at multiple usageID. I found newer Ledger devices were failing to be discovered on Mac because they have a usageID value of 0 instead of originally 0xffa0.

To keep backward compatibility now both usageID values are supported.

@felipe-op felipe-op requested a review from karalabe as a code owner January 24, 2024 01:42
@holiman
Copy link
Copy Markdown
Contributor

holiman commented Jan 24, 2024

Didn't we already discuss something very similar to this PR, here: #28516 ? The conclusion from there was that the PR here will fix the issue(s) on mac.

@felipe-op
Copy link
Copy Markdown
Author

I just re-read the whole convo @holiman -

I still will keep this open for anyone that may want to unblock themselves until the long term fix is fully merged.

@lightclient
Copy link
Copy Markdown
Member

lightclient commented Jan 25, 2024

We have the ticket #28711, I think that should suffice for anyone looking into this issue seeking a short term solution. Since we're going to fix the issue by updating karalabe/usb I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants