graphql: change the type of yParity from Long to BigInt#28456
Merged
s1na merged 1 commit intoethereum:masterfrom Nov 9, 2023
Merged
graphql: change the type of yParity from Long to BigInt#28456s1na merged 1 commit intoethereum:masterfrom
s1na merged 1 commit intoethereum:masterfrom
Conversation
Signed-off-by: jsvisa <delweng@gmail.com>
Contributor
|
It's not necessary to return a bigint here, because the only possible values are |
Contributor
Author
Yes, it's enough for storing the data, but here we want to align with |
s1na
approved these changes
Nov 9, 2023
Contributor
s1na
left a comment
s1na
left a comment
There was a problem hiding this comment.
Honestly they are the same. both types are formatted the same way. Felix merged the spec so this is good to go.
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Signed-off-by: jsvisa <delweng@gmail.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 813f62f.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 813f62f.
Dergarcon
pushed a commit
to MetaMask/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
Signed-off-by: jsvisa <delweng@gmail.com>
colinlyguo
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 31, 2024
Signed-off-by: jsvisa <delweng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in ethereum/execution-apis#471
as
r,s,vare bigints, so yParity should also be the same.