Skip to content

fixing blobpool metrics name from - to _ for prometheus#27901

Merged
karalabe merged 1 commit intoethereum:masterfrom
imulmat4:fix_blobpool_metric_name
Aug 11, 2023
Merged

fixing blobpool metrics name from - to _ for prometheus#27901
karalabe merged 1 commit intoethereum:masterfrom
imulmat4:fix_blobpool_metric_name

Conversation

@imulmat4
Copy link
Copy Markdown
Contributor

@imulmat4 imulmat4 commented Aug 10, 2023 •
edited
Loading

Created this PR per #27900. I am running telegraf as a prometheus server and unable to scrape metrics because the blobpool metrics does not conform to Prometheus metrics naming standards. Please refer to https://prometheus.io/docs/practices/naming/.
All I am doing is changing the - to a _.
I tested and built this and my node was syncing and metrics names are still easily readable:

blobpool_shelf_3_slotused 0

# TYPE blobpool_shelf_4_datagaps gauge
blobpool_shelf_4_datagaps 0

Apologies if I missed something here. First time open a PR in this repo.

@imulmat4 imulmat4 mentioned this pull request Aug 10, 2023
Closed
@karalabe
Copy link
Copy Markdown
Member

karalabe commented Aug 11, 2023

Ah, bummer. Ok, we can do that, thx

karalabe
karalabe approved these changes Aug 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.12.2 milestone Aug 11, 2023
@karalabe karalabe merged commit 6ddb92c into ethereum:master Aug 11, 2023
fjl pushed a commit that referenced this pull request Aug 12, 2023
@imulmat4 @fjl
core/txpool/blobpool: fix metrics name for prometheus export (#27901)
55863ce
@claudiughioc claudiughioc mentioned this pull request Sep 27, 2023
Closed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@imulmat4 @devopsbo3
core/txpool/blobpool: fix metrics name for prometheus export (ethereu…
e9a6ee6 
…m#27901)
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core/txpool/blobpool: fix metrics name for prometheus export (e…
a21e703 
…thereum#27901)"

This reverts commit e9a6ee6.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core/txpool/blobpool: fix metrics name for prometheus export (e…
23c21a9 
…thereum#27901)"

This reverts commit e9a6ee6.
weiihann pushed a commit to weiihann/go-ethereum that referenced this pull request Mar 13, 2024
@imulmat4 @weiihann
core/txpool/blobpool: fix metrics name for prometheus export (ethereu…
4994378 
…m#27901)
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Mar 17, 2024
@weiihann @imulmat4
core/txpool/blobpool: fix metrics name for prometheus export (ethereu…
80e148b 
…m#27901) (#403)

Co-authored-by: imulmat4 <117636097+imulmat4@users.noreply.github.com>
gballet pushed a commit to gballet/go-ethereum that referenced this pull request May 7, 2024
@weiihann @imulmat4 @gballet
core/txpool/blobpool: fix metrics name for prometheus export (ethereu…
7af7e5c 
…m#27901) (#403)

Co-authored-by: imulmat4 <117636097+imulmat4@users.noreply.github.com>
gballet pushed a commit to gballet/go-ethereum that referenced this pull request May 8, 2024
@weiihann @imulmat4 @gballet
core/txpool/blobpool: fix metrics name for prometheus export (ethereu…
a3232b7 
…m#27901) (#403)

Co-authored-by: imulmat4 <117636097+imulmat4@users.noreply.github.com>
gballet pushed a commit to gballet/go-ethereum that referenced this pull request May 8, 2024
@weiihann @imulmat4 @gballet
core/txpool/blobpool: fix metrics name for prometheus export (ethereu…
c1e8a19 
…m#27901) (#403)

Co-authored-by: imulmat4 <117636097+imulmat4@users.noreply.github.com>
@bgiegel bgiegel mentioned this pull request Jul 18, 2024
Merged
@intx4 intx4 mentioned this pull request Oct 1, 2024
Merged
@bgiegel bgiegel mentioned this pull request Jan 31, 2025
Merged
@oxbee oxbee mentioned this pull request Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holiman holiman Awaiting requested review from holiman

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

1 more reviewer

@karalabe karalabe karalabe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.12.2

Development

Successfully merging this pull request may close these issues.

2 participants

@imulmat4 @karalabe