Skip to content

crypto/secp256k1: define NDEBUG only if not defined#27550

Merged
fjl merged 1 commit into
ethereum:masterfrom
fbac:crypto-ifndef-ndebug
Jun 23, 2023
Merged

crypto/secp256k1: define NDEBUG only if not defined#27550
fjl merged 1 commit into
ethereum:masterfrom
fbac:crypto-ifndef-ndebug

Conversation

@fbac
Copy link
Copy Markdown
Contributor

@fbac fbac commented Jun 23, 2023

NDEBUG can be defined in some architechtures, by checking it with ifndef we avoid compiler warning problems, such as:

Error: ../../../go/pkg/mod/github.com/ethereum/go-ethereum@v1.10.26/crypto/secp256k1/secp256.go:28:9: warning: 'NDEBUG' macro redefined [-Wmacro-redefined]

@fjl fjl changed the title crypto: define NDEBUG only if not defined crypto/secp256k1: define NDEBUG only if not defined Jun 23, 2023
@fjl fjl merged commit 942ba4d into ethereum:master Jun 23, 2023
@fbac fbac deleted the crypto-ifndef-ndebug branch June 23, 2023 21:22
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
eomti-wm pushed a commit to wemixarchive/go-wemix that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants