EIP-7212: precompile for secp256r1 curve by ulerdogan · Pull Request #27540 · ethereum/go-ethereum

ulerdogan · 2023-06-22T12:41:47Z

The PR is about EIP-7212 which proposes the addition of a new precompiled contract to the EVM that allows signature verifications in the “secp256r1” elliptic curve by given parameters of message hash, r - s components of the signature, and x - y coordinates of the public key.

nlok5923

Thanks for your contribution can you look into the comments

nlok5923 · 2023-06-27T04:55:35Z

+// Run executes the precompiled contract, returning the output and the used gas
+func (c *p256Verify) Run(input []byte) ([]byte, error) {
+	// Required input length is 160 bytes
+	const p256VerifyInputLength = 160


Can we put some constraints here to make sure the input provided should scope to 160 bytes only to avoid unnecessary execution?

I assume you mean to halt precompile execution in an exceptional state? The EIP doesn't specify this behavior so it shouldn't be added here.

it seems clean for the precompile to always return 1 or 0.

might be worth specifying that it return 0 if the input is not exactly 160 bytes. any other input length indicates an error in the calling contract.

also, what happens if a nonzero value is included with the call?

cc @ulerdogan

Just a note, we do not care about value transmitted to precompiles via call. None of the other precompiles check for it.

dcposch · 2023-10-07T18:02:50Z

 	}

-	// Check the malleability issue
-	if checkMalleability(s) {


holiman · 2023-11-28T17:41:42Z

As far as I know, this is not slated for any upcoming hardfork. I'll close this, feel free to reopen if it becomes scheduled.

ulerdogan · 2023-11-29T15:23:54Z

Hey @holiman, thanks for following up! Yes, the EIP is not scheduled for any hard forks, so I think good to keep as a closed PR.

The proposal is currently being discussed to re-created as an RIP and then, most of the rollups are planning to integrate into their chains. So, I will apply any specification changes to this PR to create a reference. For example, I will start by changing the implementation address (got advised from 'lightclient' to apply to another address in the RIP roadmap) when the update PR get merged.

ulerdogan · 2023-11-30T19:51:58Z

+// PrecompiledContractsP256Verify contains the precompiled Ethereum
+// contract specified in EIP-7212. This is exported for testing purposes.
+var PrecompiledContractsP256Verify = map[common.Address]PrecompiledContract{
+	common.BytesToAddress([]byte{19}): &p256Verify{},
+}
+


The implementation address updated to 0x0b due to the EIP specification in my branch with this commit, but have not synced into this branch as it's closed.

// PrecompiledContractsP256Verify contains the precompiled Ethereum // contract specified in EIP-7212. This is exported for testing purposes. var PrecompiledContractsP256Verify = map[common.Address]PrecompiledContract{ common.BytesToAddress([]byte{0x0b}): &p256Verify{}, }

The implementation address updated to 0x100 again with this commit as the EIP moved into the RIPs repo and this range has been attached for the RIP precompiles.

// PrecompiledContractsP256Verify contains the precompiled Ethereum // contract specified in RIP-7212. This is exported for testing purposes. var PrecompiledContractsP256Verify = map[common.Address]PrecompiledContract{ common.BytesToAddress([]byte{0x01, 0x00}): &p256Verify{}, }

Initial support of the upcoming Napoli hard fork on Polygon – see [PIP-33](https://forum.polygon.technology/t/pip-33-napoli-upgrade). Per [PIP-31](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-31.md), it parallels the [Cancun](https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/cancun.md) upgrade of Ethereum, but does not include [EIP-4788](https://eips.ethereum.org/EIPS/eip-4788), [EIP-4844](https://eips.ethereum.org/EIPS/eip-4844), [EIP-7516](https://eips.ethereum.org/EIPS/eip-7516). In other words, Napoli includes [EIP-1153](https://eips.ethereum.org/EIPS/eip-1153), [EIP-5656](https://eips.ethereum.org/EIPS/eip-5656), [EIP-6780](https://eips.ethereum.org/EIPS/eip-6780) from Cancun. This PR implements [PIP-31](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-31.md), [PIP-16: Transaction Dependency Data](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-16.md) (by merging `ParallelUniverseBlock` into `NapoliBlock`; the bulk of PIP-16 was implemented in PR #8037), and [PIP-27: Precompiled for secp256r1 Curve Support](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-27.md) ([EIP-7212](https://eips.ethereum.org/EIPS/eip-7212); see also 0xPolygon/bor#1069 & ethereum/go-ethereum#27540). --------- Co-authored-by: Anshal Shukla <shukla.anshal85@gmail.com>

ethereum/EIPs#9833 Based on #27540, #30043 --------- Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>

ethereum/EIPs#9833 Based on ethereum#27540, ethereum#30043 --------- Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>

ulerdogan added 9 commits May 8, 2023 04:11

crypto/secp2561r1: add secp256r1 curve verifiers

fb89b61

core/vm: implement secp256r1 verifier precompiled

a8c0a2e

params: add new precompiled gas price

c0554c0

core/vm, params: rename precompiled to p256verify

6c7028a

core/vm: simplify the return values format

d245194

crypto/secp25r1: fix reverse malleability issue

066a31f

core/vm: fix testdata non-malleable for p256Verify

ec17e78

all: merge branch master into ulerdogan-secp256r1

6bf9e70

core/vm: update the eip number

f5b6d7e

ulerdogan requested review from holiman, karalabe and rjl493456442 as code owners June 22, 2023 12:41

fjl changed the title ~~New EIP: Precompiled for secp256r1 Curve Support~~ EIP-7212: precompile for secp256r1 curve Jun 22, 2023

fjl reviewed Jun 22, 2023

View reviewed changes

Comment thread crypto/secp256r1/verifier.go Outdated

Comment thread core/vm/contracts.go Outdated

core, crypto/secp256r1: fix error reverts tx error

2820903

ulerdogan requested a review from fjl June 22, 2023 22:14

nlok5923 suggested changes Jun 27, 2023

View reviewed changes

dcposch reviewed Aug 10, 2023

View reviewed changes

Comment thread core/vm/contracts.go

dcposch reviewed Aug 10, 2023

View reviewed changes

Comment thread crypto/secp256r1/verifier.go Outdated

crypto/secp256r1: refactor by simplfying return

1be1875

ulerdogan mentioned this pull request Sep 10, 2023

Update EIP-7212: Clarifications and improvements ethereum/EIPs#7676

Merged

fjl reviewed Sep 22, 2023

View reviewed changes

Comment thread core/vm/contracts.go Outdated

ulerdogan and others added 4 commits September 24, 2023 04:42

core/vm: force the input length of p256verify

21f4932

crypto/secp256r1: reject the reference pubKey coordinates

98f10b0

Merge branch 'master' into ulerdogan-secp256r1

7e0bc92

crypto/secp256r1: remove malleability check due to spec

cec0b05

dcposch reviewed Oct 7, 2023

View reviewed changes

Comment thread crypto/secp256r1/verifier.go Outdated

}

// Check the malleability issue

if checkMalleability(s) {

Copy link
Copy Markdown

dcposch Oct 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fedekunze mentioned this pull request Oct 22, 2023

feat(precompiles): EIP-7212: secp256r1 curve evmos/evmos#1922

Merged

mdehoog mentioned this pull request Oct 25, 2023

Fjord: secp256r1 curve support (RIP-7212) ethereum-optimism/op-geth#168

Merged

anshalshukla mentioned this pull request Nov 3, 2023

EIP7212 / PIP27 0xPolygon/bor#1069

Merged

18 tasks

holiman closed this Nov 28, 2023

ulerdogan commented Nov 30, 2023

View reviewed changes

ulerdogan mentioned this pull request Dec 21, 2023

Update RIP-7212: Last Call deadline added, implementation address changed ethereum/RIPs#6

Merged

This was referenced Jan 17, 2024

EIP-7212 / PIP-27: Precompile for secp256r1 Curve Support erigontech/erigon#9252

Closed

Implement PIP-33: Napoli Hardfork erigontech/erigon#8975

Merged

Quentash mentioned this pull request Apr 18, 2024

Feat: add RIP-7212 to the list of precompiles Cairo1Helpers module kkrt-labs/kakarot-ssj#779

Merged

9 tasks

jonastheis mentioned this pull request Jun 5, 2024

feat: implement RIP-7212/EIP-7212 scroll-tech/go-ethereum#798

Merged

13 tasks

alexb5dh mentioned this pull request Jun 12, 2024

EIP/RIP-7212 NethermindEth/nethermind#7135

Merged

7 tasks

ulerdogan mentioned this pull request Jun 21, 2024

RIP-7212 Implementation, Prague-CFI #30043

Closed

colinlyguo mentioned this pull request Feb 5, 2025

feat: enable p256Verify in EuclidV2 scroll-tech/go-ethereum#1111

Merged

3 tasks

This was referenced Jun 9, 2025

Fusaka Fork Planning #31701

Closed

EIP-7951: Precompile for secp256r1 Curve Support #31991

Merged

fjl added a commit that referenced this pull request Jul 7, 2025

core/vm: implement EIP-7951 - precompile for secp256r1 (#31991)

b3131f0

ethereum/EIPs#9833 Based on #27540, #30043 --------- Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>

Conversation

ulerdogan commented Jun 22, 2023

Uh oh!

Uh oh!

Uh oh!

nlok5923 left a comment

Choose a reason for hiding this comment

Uh oh!

nlok5923 Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

jwasinger Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

dcposch Aug 10, 2023

Choose a reason for hiding this comment

Uh oh!

fjl Sep 22, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dcposch Oct 7, 2023

Choose a reason for hiding this comment

Uh oh!

holiman commented Nov 28, 2023

Uh oh!

ulerdogan commented Nov 29, 2023

Uh oh!

ulerdogan Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

ulerdogan Dec 21, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants