Skip to content

rlp, apitypes; use slices package for sorting#27495

Closed
danlaine wants to merge 1 commit into
ethereum:masterfrom
danlaine:use-slices-package-for-sorting-rlp-signer
Closed

rlp, apitypes; use slices package for sorting#27495
danlaine wants to merge 1 commit into
ethereum:masterfrom
danlaine:use-slices-package-for-sorting-rlp-signer

Conversation

@danlaine
Copy link
Copy Markdown

See #27474

@danlaine danlaine requested a review from holiman as a code owner June 16, 2023 13:52
@fjl
Copy link
Copy Markdown
Contributor

fjl commented Jun 16, 2023

Replacing sort.Strings by slices.Sort seems weird to me. It makes sense to do the replacement if it allows removing an implementation of sort.Interface. But that's not the case here.

Also, both of these places are absolutely not performance-critical.

@fjl fjl closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants