Skip to content

accounts: replace noarg fmt.Errorf with errors.New#27331

Merged
holiman merged 2 commits into
ethereum:masterfrom
jsvisa:accounts-errorf
May 25, 2023
Merged

accounts: replace noarg fmt.Errorf with errors.New#27331
holiman merged 2 commits into
ethereum:masterfrom
jsvisa:accounts-errorf

Conversation

@jsvisa
Copy link
Copy Markdown
Contributor

@jsvisa jsvisa commented May 24, 2023

similar to #27329

Signed-off-by: jsvisa <delweng@gmail.com>
@s1na
Copy link
Copy Markdown
Contributor

s1na commented May 24, 2023

A test is broken:

# github.com/ethereum/go-ethereum/accounts/keystore [github.com/ethereum/go-ethereum/accounts/keystore.test]
accounts\keystore\account_cache_test.go:77:12: undefined: errors
FAIL	github.com/ethereum/go-ethereum/accounts/keystore [build failed]

Signed-off-by: jsvisa <delweng@gmail.com>
@holiman holiman added this to the 1.12.1 milestone May 25, 2023
@holiman holiman merged commit 9358b62 into ethereum:master May 25, 2023
@jsvisa jsvisa deleted the accounts-errorf branch May 25, 2023 12:48
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
* accounts: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <delweng@gmail.com>

* accounts: go autoimport

Signed-off-by: jsvisa <delweng@gmail.com>

---------

Signed-off-by: jsvisa <delweng@gmail.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025
* accounts: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <delweng@gmail.com>

* accounts: go autoimport

Signed-off-by: jsvisa <delweng@gmail.com>

---------

Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants