cmd/utils: don't check free disk space in dev mode#27281
Merged
Conversation
jwasinger
reviewed
May 16, 2023
Contributor
jwasinger
left a comment
jwasinger
left a comment
There was a problem hiding this comment.
In my opinion, it would be slightly better to do this check when determining if monitorFreeDiskSpace should be invoked.
holiman
approved these changes
May 17, 2023
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
By merging the only functional difference will be that the warning is not printed. But sure, why not, I guess.
As for whether to do it within monitorFreeDiskSpace or outside, in cmd/utils/cmd.go before calling go monitorFreeDiskSpace(..., I don't really have any opinion.
Member
|
I think both approaches are fine for me, either check in |
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data dir is empty when using dev mode.