cmd/geth: remove DAO fork test#27161
Merged
holiman merged 2 commits intoethereum:masterfrom Apr 25, 2023
Merged
Conversation
Contributor
|
We should honestly just delete this test instead of fixing it like that. |
Contributor
Author
|
Fair enough. I'll do that then 😢 |
fjl
changed the title
fjl
approved these changes
Apr 25, 2023
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
* cmd/geth: fix test to not use explicit db * cmd/geth: remove dao-test
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* cmd/geth: fix test to not use explicit db * cmd/geth: remove dao-test
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 0a895cb.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 0a895cb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a test which fails on 32-bit platforms, since #27136 made it "blindly" use pebble.
The fix in this PR uses the
geth db getfunctionality to retrieve data from the db, which leaves it up to the geth internals to figure out what db to use.An alternative to this fix would be to simply nuke the dao-test from the repo.