Skip to content

miner: add logs for displaying fees change#26097

Merged
holiman merged 4 commits intoethereum:masterfrom
rjl493456442:add-miner-log
Nov 3, 2022
Merged

miner: add logs for displaying fees change#26097
holiman merged 4 commits intoethereum:masterfrom
rjl493456442:add-miner-log

Conversation

@rjl493456442
Copy link
Copy Markdown
Member

No description provided.

Comment thread miner/payload_building.go Outdated
Copy link
Copy Markdown
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjl493456442
Copy link
Copy Markdown
Member Author

rjl493456442 commented Nov 3, 2022

todo: fix the mutex stuff in this PR done

Copy link
Copy Markdown
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Copy link
Copy Markdown
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.11.0 milestone Nov 3, 2022
@holiman holiman merged commit 08fb1aa into ethereum:master Nov 3, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
* miner: add logs for displaying fees change

* miner: simplify feesInEther calculation

* miner: fix lock

* miner: change to default recommit to 2 seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants