cmd/devp2p/internal/v4test: ignore FINDNODE in BondThenPingWithWrongFrom#26085
Merged
fjl merged 5 commits intoethereum:masterfrom Nov 7, 2022
Merged
cmd/devp2p/internal/v4test: ignore FINDNODE in BondThenPingWithWrongFrom#26085fjl merged 5 commits intoethereum:masterfrom
fjl merged 5 commits intoethereum:masterfrom
Conversation
This reverts commit 3a6779d.
Contributor
Interesting. @fjl? |
fjl
approved these changes
Nov 7, 2022
fjl
changed the title
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
…rom (ethereum#26085) This fixes a race in the test. Co-authored-by: Felix Lange <fjl@twurst.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nethermind is sometimes failing hive test
BondThenPingWithWrongFrombecause of sendingFindNodeinstead of expectedPong. SometimesPongis our first response and then we are passing this test. As we were bonded before receivingPing, we consider sendingFindNodeas acceptable. This PR is changing testBondThenPingWithWrongFromto ignore receivedFindNodewhile waiting forPongresponse.I tested it and after changes from this PR we are always passing
BondThenPingWithWrongFrom.