accounts/abi.bind: don't fetch head in transact unless required

[saman-pasha]

if GasFeeCap and GasTipCap are specified no need to retrieve head

[Szybka22]

.devcontainer/Dockerfile

[MariusVanDerWijden]

The change looks kinda reasonable to me, could you explain your reasoning a bit more and add a test maybe?

[rjl493456442]

@MariusVanDerWijden I guess it's for avoiding fetching head. Since we are already in London fork and 1559 is already activated, it's unnecessary to apply the check(header.basefee == nil) at this moment.

But personally I still feel the check is necessary, mostly for other geth-based chains. They may or may not activate the 1559.

[saman-pasha]

The change looks kinda reasonable to me, could you explain your reasoning a bit more and add a test maybe?

I have used abigen to generate code for create and sends some transactions to a contract, but in some cases I dont need to send a tx I only need to produce a tx so I have used TransactOpts.NoSend and I send nil to NewContract instance as the client.
When I set GasPrice I dont get any error and tx is produced but when I set GasFeeCap and GasTipCap to use tx.Type = 2 EIP 1559, it returns nil error because it feches head to set fees and needs a client insrance, so if it checks those fees are set no need to fetch head and tx is produced

[rjl493456442]

Maybe you can just setup the client instance?

[saman-pasha]

When I want to use EIP-712 to produce input data and I dont have access to Internet so fetching head is just an overhead and a problem

[rjl493456442]

I get your point, but I don't think we will hold the condition that: sign transaction doesn't need any network connection.

There are a few cases that we need to retrieve information from the node to fulfill the transaction a bit

• GasLimit is missing: estimate gas usage
• GasPrice is missing: query price oracle for recommendation
• Nonce is missing: retrieve nonce

Generally, the network access is required in our library I think.

[rjl493456442]

Clef is another tool which designed for off-line signing, which also supports EIP-712. Maybe it's something suitable for you?https://geth.ethereum.org/docs/clef/introduction

[holiman]

LGTM