trie: test for edgecase in VerifyRangeProof#24257
Merged
holiman merged 3 commits intoethereum:masterfrom Jan 21, 2022
Merged
Conversation
Contributor
|
Thanks for the PR! Good find |
b5c08e2 to
094cdac
Compare
Contributor
|
I've rebased this on master, and removed the todo left there. Should be good to go now |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 21, 2022
* trie/proof: edge case for VerifyRangeProof * more consistency with other tests in the file * trie: fix test todo Co-authored-by: Martin Holst Swende <martin@swende.se>
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* trie/proof: edge case for VerifyRangeProof * more consistency with other tests in the file * trie: fix test todo Co-authored-by: Martin Holst Swende <martin@swende.se>
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 9, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 8, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 20, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably a case where I am setting up something incorrectly, though the test fails when I remove the 1st elements of
keysandvals(but passes otherwise). I was hoping you could take a look, since I couldn't exactly figure it out.I'm assuming it's because there's a shared prefix on the keys, though not sure.
This is the stack trace I am getting: