Skip to content

miner: update pending block even after the PoS transition#24075

Merged
holiman merged 1 commit intoethereum:masterfrom
rjl493456442:miner-fix
Dec 7, 2021
Merged

miner: update pending block even after the PoS transition#24075
holiman merged 1 commit intoethereum:masterfrom
rjl493456442:miner-fix

Conversation

@rjl493456442
Copy link
Copy Markdown
Member

@rjl493456442 rjl493456442 commented Dec 7, 2021

Whenever The Merge happens, the pow mining will be meaningless and be disabled by default in miner package. However miner package is still responsible for creating/maintaining the pending block/state for API usage.

This PR re-enables this functionality.

Copy link
Copy Markdown
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.14 milestone Dec 7, 2021
Copy link
Copy Markdown
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holiman holiman merged commit 7f7877a into ethereum:master Dec 7, 2021
ivanshukhov pushed a commit to Kapoio/go-kapoio that referenced this pull request Dec 11, 2021
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants