les/vflux: fixed panic and data races#23865
Merged
zsfelfoldi merged 2 commits intoethereum:masterfrom Nov 8, 2021
Merged
Conversation
holiman
approved these changes
Nov 7, 2021
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
Looks.. like it can't do no harm..
yolo
rjl493456442
approved these changes
Nov 8, 2021
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 8, 2021
* les/vflux/server: fix BalanceOperation * les/vflux/client: fixed data races
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
* les/vflux/server: fix BalanceOperation * les/vflux/client: fixed data races
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a faulty condition in the les/vflux/server package that caused BalanceOperation to panic in some rare cases. The data races reported in #23848 are also fixed in les/vflux/client.