accounts/abi/bind/backends: make suggestGP compatible with non-1559 chains#23840
Merged
holiman merged 1 commit intoethereum:masterfrom Nov 1, 2021
Merged
Conversation
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 1, 2021
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #23836
Makes suggestGasPrice behave properly even if the header has no basefee (pre-eip1559)
This should not actually happen as the
SimulatedBackendhasAllEthashChangesbuild in, but it's more correct imo.