Skip to content

cmd/evm: add 256-bit field validations on transactions (t9n)#23743

Merged
holiman merged 3 commits intoethereum:masterfrom
holiman:t9n_256bit_validations
Oct 18, 2021
Merged

cmd/evm: add 256-bit field validations on transactions (t9n)#23743
holiman merged 3 commits intoethereum:masterfrom
holiman:t9n_256bit_validations

Conversation

@holiman
Copy link
Copy Markdown
Contributor

@holiman holiman commented Oct 15, 2021

Fixes #23740

Additionally, it checks the extra fields in type-2 (1559) transactions.

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Oct 15, 2021

Updated to also validate that gas * gasPrice is within 256 bits, and output intrinsic gas (if we got that far)
Fixes #23746

Comment thread cmd/evm/internal/t8ntool/transaction.go
@holiman holiman merged commit 84d8eb2 into ethereum:master Oct 18, 2021
@holiman holiman added this to the 1.10.11 milestone Oct 18, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 20, 2021
…m#23743)

* cmd/evm: add 256-bit field validations on transactions (t9n)

* cmd/evm: validate gas*gasPrice, return intrinsic gas usage

* cmd/evm: address review comment
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
…m#23743)

* cmd/evm: add 256-bit field validations on transactions (t9n)

* cmd/evm: validate gas*gasPrice, return intrinsic gas usage

* cmd/evm: address review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

evm t9n export transaction intrinsic gas if transaction is valid evm t9n should reject values greater than 256-bit for gasPrice and Value

2 participants