-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/geth: add support for sepolia testnet #23730
Conversation
Something is wrong with this PR, it doesn't actually populate the allocs. |
Genesis block hash: Full json: {
"config":{
"chainId":11155111,
"homesteadBlock":0,
"eip150Block":0,
"eip155Block":0,
"eip158Block":0,
"byzantiumBlock":0,
"constantinopleBlock":0,
"petersburgBlock":0,
"istanbulBlock":0,
"berlinBlock":0,
"londonBlock":0
},
"alloc":{
"0xa2A6d93439144FFE4D27c9E088dCD8b783946263": {"balance": "0xD3C21BCECCEDA1000000"},
"0xBc11295936Aa79d594139de1B2e12629414F3BDB": {"balance": "0xD3C21BCECCEDA1000000"},
"0x7cF5b79bfe291A67AB02b393E456cCc4c266F753": {"balance": "0xD3C21BCECCEDA1000000"},
"0xaaec86394441f915bce3e6ab399977e9906f3b69": {"balance": "0xD3C21BCECCEDA1000000"},
"0xF47CaE1CF79ca6758Bfc787dbD21E6bdBe7112B8": {"balance": "0xD3C21BCECCEDA1000000"},
"0xd7eDDB78ED295B3C9629240E8924fb8D8874ddD8": {"balance": "0xD3C21BCECCEDA1000000"},
"0x8b7F0977Bb4f0fBE7076FA22bC24acA043583F5e": {"balance": "0xD3C21BCECCEDA1000000"},
"0xe2e2659028143784d557bcec6ff3a0721048880a": {"balance": "0xD3C21BCECCEDA1000000"},
"0xd9a5179f091d85051d3c982785efd1455cec8699": {"balance": "0xD3C21BCECCEDA1000000"},
"0xbeef32ca5b9a198d27B4e02F4c70439fE60356Cf": {"balance": "0xD3C21BCECCEDA1000000"},
"0x0000006916a87b82333f4245046623b23794c65c": {"balance": "0x84595161401484A000000"},
"0xb21c33de1fab3fa15499c62b59fe0cc3250020d1": {"balance": "0x52B7D2DCC80CD2E4000000"},
"0x10F5d45854e038071485AC9e402308cF80D2d2fE": {"balance": "0x52B7D2DCC80CD2E4000000"},
"0xd7d76c58b3a519e9fA6Cc4D22dC017259BC49F1E": {"balance": "0x52B7D2DCC80CD2E4000000"},
"0x799D329e5f583419167cD722962485926E338F4a": {"balance": "0xDE0B6B3A7640000"}
},
"coinbase":"0x0000000000000000000000000000000000000000",
"difficulty":"0x20000",
"extraData":"0x5365706f6c69612c20417468656e732c204174746963612c2047726565636521",
"gasLimit":"0x1c9c380",
"nonce":"0x000000000000000",
"mixhash":"0x0000000000000000000000000000000000000000000000000000000000000000",
"parentHash":"0x0000000000000000000000000000000000000000000000000000000000000000",
"timestamp":"0x6159af19"
}
|
cc @parithosh we may need to reboot sepolia with these changes. |
Sorry, cc:ed the wrong person, should be @shivamagl95 |
@holiman done. |
Hm, tried a sync
|
The miner seems a bit 'toast':
It's a non-contiguous chain. It was mining fine, but somehow started syncing with another node:
And somehow wound up with a non-contiguous chain. |
@garyschulte started a besu-node mining, which is probably the one our miner started syncing from. This is their blocks, where our is non-continuuous;
Theirs is continuous. |
Geth has a bug if it's mining on initial empty db and then syncs. Same
happens on Clique signers too btw, there they just mess up block 1. I think
I opened an issue a year or two ago about it. Miners need to sync first,
then mine as a workaround.
…On Tue, Oct 19, 2021, 19:33 Martin Holst Swende ***@***.***> wrote:
@garyschulte <https://github.com/garyschulte> started a besu-node mining,
which is probably the one our miner started syncing from. This is their
blocks, where our is non-continuuous;
"number": "0x82bb",
"hash": "0x7e6c23628202f033bbe97466cd0ee1f570990c9981cdd168f38481faed2f9b35",
"mixHash": "0xf4a5cf17912fd320c671ebed7d49e972d399b2589bea2f85327322c4d6dc81cb",
"parentHash": "0x940f9fc318492c0cf9ae005de92cb24b91b7b31af9c59b897e3ebab6e54b0c28",
"nonce": "0x62cf4323b89da529",
...
"number": "0x82bc",
"hash": "0x899fb6b74fe446fd01542fef4c4e2e77b0c02706d7b7a7bf51236b2193a5022c",
"mixHash": "0xd5c063cb485336897f27bbe14f9c82567f36e4b66a043b5dae77bc0272bb0c4e",
"parentHash": "0x7e6c23628202f033bbe97466cd0ee1f570990c9981cdd168f38481faed2f9b35",
"nonce": "0x62cf4323b8c16f92",
Theirs is continuous.
I'm guessing our miner-direct-write-block has some flaw, when combined
with sync suddenly kicking in.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#23730 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7UGLCOWGFZV2HR6XRKKLUHWMWNANCNFSM5F5I2Q2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
FWIW, at the time I started the miner the geth node had 33k blocks in its db already. |
I guess we should just wipe the miner, let it resync, and then start mining again later on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
* cmd/geth: add support for sepolia testnet * core: last details on sepolia genesis * params: fix sepolia hash + reduce testing code * Update params/bootnodes.go * cmd/geth: fix attach path for sepolia * params: update bootnodes * params: fix * core: fix docstring * params: add sepolia CHT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belki de çalışmak zorunda kaldık
This PR adds suppor for 'Sepolia', a new testnet to replace ropsten. It differs a bit from what's already running, since I noticed that the existing one has a genesis difficult of
0x200
, which is below the minimum of0x2000
. When the difficulty is below that value, the YP difficulty calculation is ambiguous.Also, the existing one had empty extradata, which might cause issues, so I added some data there.