miner: Ensure the miner is closed#23675
Closed
piersy wants to merge 1 commit intoethereum:masterfrom
Closed
Conversation
piersy
requested review from
holiman,
karalabe and
rjl493456442
as code owners
Also make miner and worker wait for goroutines to end at Shutdown. Without this change, when shutting down its possible for the worker to try and access the db after it has been closed, which results in a critical failure and runs the risk of corrupting the db.
piersy
force-pushed
the
close-miner-and-wait-for-goroutines-to-exit
branch
from
082ec8f to
2f01ef3
Compare
Contributor
|
Heh, this also reminds me of a PR I already have: #21992 |
Contributor
Author
Heh, strangely similar, they basically do exactly the same thing :) I prefer yours over mine for the fact that you used a wg in the miner which just keeps the approach consistent, and I prefer mine over yours for the use of function closures to handle the wg which keeps the calls to Add and Done close together in the code. So feel free to close this PR, I don't think its adding anything functionally over your PR. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make miner and worker wait for goroutines to end at Shutdown.
Without this change, when shutting down its possible for the worker to
try and access the db after it has been closed, which results in a
critical failure and runs the risk of corrupting the db.