graphql: add storage slots to access list#23650
Merged
fjl merged 2 commits intoethereum:masterfrom Sep 28, 2021
Merged
Conversation
karalabe
reviewed
Sep 28, 2021
| accessList := tx.AccessList() | ||
| ret := make([]*AccessTuple, 0, len(accessList)) | ||
| for _, al := range accessList { | ||
| var sKeys []common.Hash |
Contributor
There was a problem hiding this comment.
Would be even better to change the type of AccessTuple.storageKeys to non-pointer.
4379773 to
7752cc3
Compare
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Sep 28, 2021
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not really certain why it didn't work previously, but for some reason, this fixes it.
Without this PR:
With this PR: