eth/protocols/eth: simplify peer known block/txs caches #23649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
reviewed
Sep 27, 2021
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
Lgtm aside from some minor nits
holiman
changed the title
karalabe
reviewed
Sep 28, 2021
karalabe
reviewed
Sep 28, 2021
holiman
approved these changes
Sep 28, 2021
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Sep 28, 2021
* Simplify peer known block/txns cache * Address minor changes * Add more minor comments * Minor changes from review
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
* Simplify peer known block/txns cache * Address minor changes * Add more minor comments * Minor changes from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
setobject that abstract the cache for known blocks and transactions.