core/rawdb: use AncientRange when initializing leveldb from freezer#23612
Merged
holiman merged 2 commits intoethereum:masterfrom Nov 23, 2021
Merged
core/rawdb: use AncientRange when initializing leveldb from freezer#23612holiman merged 2 commits intoethereum:masterfrom
holiman merged 2 commits intoethereum:masterfrom
Conversation
Contributor
Author
|
Some hands-on testing, initializing Using First run with this PR, with an off-by-one error I unintentionally left in: Second run, with off by one error fixed: So, it seems to work (now), and goes from |
cb204e9 to
344b53e
Compare
HoneyCivik
approved these changes
Sep 22, 2021
344b53e to
64ca976
Compare
Contributor
Author
|
Rebased, PTAL |
Contributor
Author
|
@rjl493456442 could you please take a look at this one? |
Contributor
Author
|
@rjl493456442 a gentle, very soft ping in your general direction... |
Contributor
Author
|
I have no idea why this was closed, I must have been tired and closed/deleted the wrong PR. PTAL |
HoneyCivik
approved these changes
Nov 19, 2021
Member
|
Sorry, I didn't check the message at all. I will check it. |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 23, 2021
…thereum#23612) * core/rawdb: utilize AncientRange when initiating from freezer * core/rawdb: remove debug sanity check
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
…thereum#23612) * core/rawdb: utilize AncientRange when initiating from freezer * core/rawdb: remove debug sanity check
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we restore from ancients, we go through them and write the
hash->numbermapping into leveldb. As of a while back, we now have a methods to read ancients sequentially a lot faster.This PR can most easily be tested by doing a
geth --goerli removedb, and leave ancients intact. Then ageth --goerli --nodiscover --maxpeers 0.The PR (in draft) contains a little self-validator, which shouldCRITif the contents is not correct.