internal/ethapi, graphql: improve handling of gpo.maxprice setting#23547
Closed
rjl493456442 wants to merge 2 commits intoethereum:masterfrom
Closed
internal/ethapi, graphql: improve handling of gpo.maxprice setting#23547rjl493456442 wants to merge 2 commits intoethereum:masterfrom
rjl493456442 wants to merge 2 commits intoethereum:masterfrom
Conversation
rjl493456442
requested review from
gballet,
holiman,
karalabe and
zsfelfoldi
as code owners
holiman
reviewed
Sep 21, 2021
Contributor
|
Note: interesting question is what happens when the maxprice is configured lower than the current basefee. In this case, geth should create a tx with maxfee = maxprice, but still use the normal tip estimation. |
fjl
changed the title
rjl493456442
force-pushed
the
fix-gasprice-limit
branch
from
0629e63 to
7f6fd54
Compare
rjl493456442
force-pushed
the
fix-gasprice-limit
branch
from
7f6fd54 to
8db2a6f
Compare
Member
Author
|
Carefully think about it. I think the correct way to limit the max gasprice is to send 1559 txs. The Close it now. Will open a PR to update the flag description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
gpo.maxpriceis only applied for transaction tip. It works before London since there is no baseFee. But after the london basefee dominates the transaction cost, thegpo.maxpriceis more or less useless right now.In this PR, the
gpo.maxpriceis applied for the final transaction gas price users need to pay, instead of only tip. And also this PR emphasizes the semantics of this flag:Maximum gas price users can affordFixes #23490