Skip to content

eth/filters: add bloom hits & misses meters #23520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s1na wants to merge 1 commit into from
Closed

eth/filters: add bloom hits & misses meters #23520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions eth/filters/filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,15 @@ import (
"github.com/ethereum/go-ethereum/core/types"
"github.com/ethereum/go-ethereum/ethdb"
"github.com/ethereum/go-ethereum/event"
"github.com/ethereum/go-ethereum/metrics"
"github.com/ethereum/go-ethereum/rpc"
)

var (
bloomHitsMeter = metrics.NewRegisteredMeter("rpc/filter/bloom/hits", nil)
bloomMissesMeter = metrics.NewRegisteredMeter("rpc/filter/bloom/misses", nil)
)

type Backend interface {
ChainDb() ethdb.Database
HeaderByNumber(ctx context.Context, blockNr rpc.BlockNumber) (*types.Header, error)
Expand Down Expand Up @@ -255,6 +261,7 @@ func (f *Filter) checkMatches(ctx context.Context, header *types.Header) (logs [
}
logs = filterLogs(unfiltered, nil, nil, f.addresses, f.topics)
if len(logs) > 0 {
bloomHitsMeter.Mark(1)
// We have matching logs, check if we need to resolve full logs via the light client
if logs[0].TxHash == (common.Hash{}) {
receipts, err := f.backend.GetReceipts(ctx, header.Hash())
Expand All @@ -268,6 +275,8 @@ func (f *Filter) checkMatches(ctx context.Context, header *types.Header) (logs [
logs = filterLogs(unfiltered, nil, nil, f.addresses, f.topics)
}
return logs, nil
} else {
bloomMissesMeter.Mark(1)
}
return nil, nil
}
Expand Down