Revert "eth, internal/ethapi: make RPC block miner field show block sealer correctly"#23466
Merged
Revert "eth, internal/ethapi: make RPC block miner field show block sealer correctly"#23466
Conversation
This was
linked to
issues
Aug 25, 2021
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 26, 2021
…ealer correctly (ethereum#23312)" (ethereum#23466) This reverts commit 57feabe.
paouvrard
added a commit
to aurora-is-near/rainbow-bridge-client
that referenced
this pull request
Sep 22, 2021
paouvrard
added a commit
to aurora-is-near/rainbow-bridge-client
that referenced
this pull request
Sep 22, 2021
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
…ealer correctly (ethereum#23312)" (ethereum#23466) This reverts commit 57feabe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #23312
See #23463
The rpc returndata uses a field
miner, but does not otherwise containcoinbase. Thus, if the caller wants to calculate the header/block hash on the remote side, it's impossible to do so since we do not provide the correctcoinbaseany longer.