cmd/geth, cmd/utils: remove legacy rpc flags by tqpcharlie · Pull Request #23358 · ethereum/go-ethereum

tqpcharlie · 2021-08-09T01:44:13Z

This PR aims to remove the legacy RPC flags that say "deprecated, will be removed in June 2021".

tqpcharlie · 2021-08-09T15:25:52Z

just curious, can I remove the rpcport flag in cmd/clef/main.go or is that seperate from the deprecated --rpcport flag?

tqpcharlie · 2021-08-10T01:44:07Z

am I missing something I need to remove? I've looked, and I honestly can't tell.

karalabe · 2021-08-10T08:37:43Z

The code doesn't compile.

tqpcharlie · 2021-08-10T13:11:15Z

I'm struggling to figure out what went wrong here:
cmd/utils/flags.go:1787:2: expected declaration, found 'switch' (typecheck)

switch {

^

https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/530318686

tqpcharlie · 2021-08-12T12:37:57Z

travis ci seems to be stuck...

tqpcharlie · 2021-08-12T14:25:31Z

just curious, can I remove the rpcport flag in cmd/clef/main.go or is that seperate from the deprecated --rpcport flag?

fixes "cmd/geth/usage.go:234:7: expected '(', found init (typecheck)"

reverts the spacing to how it was before I resolved the merge conflict

tqpcharlie · 2021-08-23T22:19:21Z

can I get a review and/or merge for this, please?

MariusVanDerWijden · 2021-08-24T06:05:12Z

@Zachinquarantine This PR does not compile. It doesn't even lint: https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/533060458
You should set up your go environment in a way that automatically lints and run go test ./... before you submit your PRs.

fix for cmd/geth/usage.go:243:17: expected operand, found ':=' (typecheck) in travis

holiman · 2021-08-25T09:24:47Z

cmd/utils/flags.go:923:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalBool(HTTPEnabledFlag.Name) && cfg.HTTPHost == "" {
	^
cmd/utils/flags.go:1082:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalIsSet(MinerEtherbaseFlag.Name) {
	^
cmd/utils/flags.go:1401:3: expected declaration, found 'if' (typecheck)
		if err = hash.UnmarshalText([]byte(parts[1])); err != nil {
		^
cmd/utils/flags.go:1423:36: expected 'IDENT', found ')' (typecheck)
			switch option := args[i+1].(type) {
			                                ^
cmd/utils/flags.go:1424:15: expected ';', found ':' (typecheck)
			case string:

You should be able to detect compilation issues via make geth or make all. And as others have pointed out running the tests locally is often a good idea.

tqpcharlie · 2021-08-25T13:28:16Z

cmd/utils/flags.go:923:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalBool(HTTPEnabledFlag.Name) && cfg.HTTPHost == "" {
	^
cmd/utils/flags.go:1082:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalIsSet(MinerEtherbaseFlag.Name) {
	^
cmd/utils/flags.go:1401:3: expected declaration, found 'if' (typecheck)
		if err = hash.UnmarshalText([]byte(parts[1])); err != nil {
		^
cmd/utils/flags.go:1423:36: expected 'IDENT', found ')' (typecheck)
			switch option := args[i+1].(type) {
			                                ^
cmd/utils/flags.go:1424:15: expected ';', found ':' (typecheck)
			case string:

You should be able to detect compilation issues via make geth or make all. And as others have pointed out running the tests locally is often a good idea.

I've ran the tests locally, and this is the only error the compiler is giving me:

cmd/utils/flags.go:923:2: expected declaration, found 'if' (typecheck)
if ctx.GlobalBool(HTTPEnabledFlag.Name) && cfg.HTTPHost == "" {

Co-authored-by: Martin Holst Swende <martin@swende.se>

fixes these errors: cmd/utils/flags_legacy.go:21:2: "strings" imported but not used (typecheck) "strings" ^ cmd/utils/flags_legacy.go:24:2: "github.com/ethereum/go-ethereum/node" imported but not used (typecheck) "github.com/ethereum/go-ethereum/node" ^

MariusVanDerWijden · 2021-08-26T05:50:36Z

The linter is still red: https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/533787275
You need to goimport -ed your files. What kind of IDE are you using? Goland and VSCode should do that automatically for you

tqpcharlie · 2021-08-26T14:45:47Z

The linter is still red: app.travis-ci.com/github/ethereum/go-ethereum/jobs/533787275
You need to goimport -ed your files. What kind of IDE are you using? Goland and VSCode should do that automatically for you

I'm using VSCode, but for some reason it hasn't fixed the goimports error when I save the file.

tqpcharlie · 2021-08-26T20:52:03Z

The linter is still red: app.travis-ci.com/github/ethereum/go-ethereum/jobs/533787275
You need to goimport -ed your files. What kind of IDE are you using? Goland and VSCode should do that automatically for you

I'm using VSCode, but for some reason it hasn't fixed the goimports error when I save the file.

Turns out it was because I hadn't configured it properly, it now passes 🎉 @MariusVanDerWijden

MariusVanDerWijden

LGTM
(This will probably break a lot of users though, as there are a lot of tutorials out there with these legacy flags)

collinpowell · 2021-10-04T18:01:08Z

Please how do i get my rpc port default is not connecting to metamask

* remove rpc flags * remove legacy rpc flags * remove legacy rpc flags * remove legacy rpc commands * (hopefully) fix most of the build errors * fix build errors https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/530318686 * cmd/utils: fix syntax error * empty commit to unbreak travis ci * fix syntax error * syntax fixes * syntax fixes * fix fixes "cmd/geth/usage.go:234:7: expected '(', found init (typecheck)" * fix * various fixes in usage.go * various fixes in flags.go * adds extra space reverts the spacing to how it was before I resolved the merge conflict * more fixes in usage.go * fix fix for cmd/geth/usage.go:243:17: expected operand, found ':=' (typecheck) in travis * Update cmd/utils/flags.go Co-authored-by: Martin Holst Swende <martin@swende.se> * fix error fixes these errors: cmd/utils/flags_legacy.go:21:2: "strings" imported but not used (typecheck) "strings" ^ cmd/utils/flags_legacy.go:24:2: "github.com/ethereum/go-ethereum/node" imported but not used (typecheck) "github.com/ethereum/go-ethereum/node" ^ * goimports Co-authored-by: Martin Holst Swende <martin@swende.se>

Zachinquarantine added 3 commits August 8, 2021 15:06

remove rpc flags

0856298

remove legacy rpc flags

7cc9d7c

remove legacy rpc flags

06c6993

tqpcharlie mentioned this pull request Aug 9, 2021

cmd/utils: actually show Aliased Flags as deprecated #23317

Closed

Merge branch 'ethereum:master' into remove-legacy-rpc

52d7b58

remove legacy rpc commands

c949201

tqpcharlie marked this pull request as ready for review August 10, 2021 01:43

tqpcharlie changed the title ~~[WIP] all: remove legacy rpc flags~~ all: remove legacy rpc flags Aug 10, 2021

(hopefully) fix most of the build errors

f89603d

Zachinquarantine added 4 commits August 10, 2021 09:13

Merge branch 'master' into remove-legacy-rpc

bc90f16

Merge branch 'ethereum:master' into remove-legacy-rpc

74ccf8c

fix build errors

4d4cb90

https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/530318686

cmd/utils: fix syntax error

098267e

Zachinquarantine added 6 commits August 13, 2021 10:19

empty commit to unbreak travis ci

a63c11a

fix syntax error

491c6c6

syntax fixes

4419448

syntax fixes

4d5ada4

fix

38d21e1

fixes "cmd/geth/usage.go:234:7: expected '(', found init (typecheck)"

fix

0b8b24d

MariusVanDerWijden requested changes Aug 17, 2021

View reviewed changes

Comment thread cmd/geth/usage.go

Comment thread cmd/geth/usage.go Outdated

Comment thread cmd/geth/usage.go Outdated

Comment thread cmd/utils/flags.go Outdated

Comment thread cmd/utils/flags.go Outdated

Comment thread cmd/utils/flags.go Outdated

Zachinquarantine added 2 commits August 17, 2021 13:48

various fixes in usage.go

9910394

various fixes in flags.go

e677550

tqpcharlie requested a review from MariusVanDerWijden August 20, 2021 14:36

Merge branch 'master' into remove-legacy-rpc

c563b84

adds extra space

e885bff

reverts the spacing to how it was before I resolved the merge conflict

nesxezcovcy4jYrxob approved these changes Aug 22, 2021

View reviewed changes

MariusVanDerWijden requested changes Aug 24, 2021

View reviewed changes

Comment thread cmd/geth/usage.go Outdated

Comment thread cmd/geth/usage.go Outdated

Comment thread cmd/geth/usage.go Outdated

Zachinquarantine added 2 commits August 24, 2021 13:31

more fixes in usage.go

747fa22

fix

483558b

fix for cmd/geth/usage.go:243:17: expected operand, found ':=' (typecheck) in travis

holiman reviewed Aug 25, 2021

View reviewed changes

Comment thread cmd/utils/flags.go Outdated

Zachinquarantine and others added 2 commits August 25, 2021 10:19

Update cmd/utils/flags.go

a3c0c97

Co-authored-by: Martin Holst Swende <martin@swende.se>

tqpcharlie requested review from MariusVanDerWijden and holiman August 25, 2021 18:18

aridee approved these changes Aug 26, 2021

View reviewed changes

goimports

d6149f7

tqpcharlie changed the title ~~all: remove legacy rpc flags~~ cmd/geth, cmd/utils: remove legacy rpc flags Aug 26, 2021

MariusVanDerWijden approved these changes Aug 27, 2021

View reviewed changes

MariusVanDerWijden added the status:triage label Sep 7, 2021

holiman merged commit 9a0df80 into ethereum:master Sep 7, 2021

holiman added this to the 1.10.9 milestone Sep 7, 2021

tqpcharlie deleted the remove-legacy-rpc branch September 7, 2021 12:19

arijitAD mentioned this pull request Oct 6, 2021

Remove depricated rpc flag from geth. vulcanize/dapptools#6

Merged

hy-net mentioned this pull request Oct 21, 2021

Removed and Retired RPC in GETH Nethereum/Nethereum#719

Closed

gastonponti mentioned this pull request Nov 16, 2021

Merge v1.10.7 celo-org/celo-blockchain#1695

Merged

Conversation

tqpcharlie commented Aug 9, 2021

Uh oh!

tqpcharlie commented Aug 9, 2021

Uh oh!

tqpcharlie commented Aug 10, 2021

Uh oh!

karalabe commented Aug 10, 2021

Uh oh!

tqpcharlie commented Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tqpcharlie commented Aug 12, 2021

Uh oh!

tqpcharlie commented Aug 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tqpcharlie commented Aug 23, 2021

Uh oh!

MariusVanDerWijden commented Aug 24, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

holiman commented Aug 25, 2021

Uh oh!

tqpcharlie commented Aug 25, 2021

Uh oh!

Uh oh!

MariusVanDerWijden commented Aug 26, 2021

Uh oh!

tqpcharlie commented Aug 26, 2021

Uh oh!

tqpcharlie commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MariusVanDerWijden left a comment

Choose a reason for hiding this comment

Uh oh!

collinpowell commented Oct 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tqpcharlie commented Aug 10, 2021 •

edited

Loading

tqpcharlie commented Aug 26, 2021 •

edited

Loading