There is no need to call ’IsLondon‘ twice #23333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to call ’IsLondon‘ twice, which may affect TPS
holiman
approved these changes
Aug 7, 2021
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM. It won't make a dent on TPS, but it doesn't hurt either.
Contributor
Author
thanks，I contribute fist time. I wish i could do more. |
karalabe
reviewed
Aug 9, 2021
Contributor
|
Thanks! |
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 15, 2021
Co-authored-by: lxex <[email protected]>
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
Co-authored-by: lxex <[email protected]>
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to call ’IsLondon‘ twice, which may affect TPS