core/rawdb: Dereference Block Number Before Logging#23328
Merged
karalabe merged 1 commit intoethereum:masterfrom Aug 4, 2021
Merged
core/rawdb: Dereference Block Number Before Logging#23328karalabe merged 1 commit intoethereum:masterfrom
karalabe merged 1 commit intoethereum:masterfrom
Conversation
patrick-ogrady
requested review from
holiman,
karalabe and
rjl493456442
as code owners
patrick-ogrady
changed the title
rjl493456442
approved these changes
Aug 4, 2021
Member
rjl493456442
left a comment
rjl493456442
left a comment
There was a problem hiding this comment.
Thanks for catching it, LGTM!
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 15, 2021
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
go-ethereumprints out the address of the block number variable (*uint64) instead of the block number (uint64) itself:This PR dereferences the block number pointer after it has been checked to be
non-nilbefore logging.