Skip to content

p2p/simulations: fix unlikely crash in probabilistic connect#23200

Merged
fjl merged 1 commit intoethereum:masterfrom
Evolution404:probabilistic
Jul 29, 2021
Merged

p2p/simulations: fix unlikely crash in probabilistic connect#23200
fjl merged 1 commit intoethereum:masterfrom
Evolution404:probabilistic

Conversation

@Evolution404
Copy link
Copy Markdown
Contributor

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?

@Evolution404 Evolution404 requested a review from fjl as a code owner July 13, 2021 02:30
@fjl fjl changed the title simulations/mocker.go when it's equal, we just skip this round p2p/simulations: fix unlikely crash in probabilistic connect Jul 29, 2021
@fjl fjl merged commit 8f11d27 into ethereum:master Jul 29, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 1, 2021
…m#23200)

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
…m#23200)

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants