all: rename internal 1559 gas fields, add support for graphql#23010
all: rename internal 1559 gas fields, add support for graphql#23010holiman merged 2 commits intoethereum:masterfrom karalabe:1559-graphql
Conversation
karalabe
requested review from
MariusVanDerWijden,
gballet,
holiman and
rjl493456442
as code owners
|
So, this changes I agree it's a step forward, and think it's better than what we have now -- but I would personally prefer |
| "gasFeeCap" : "0xfa0", | ||
| "gasTipCap" : "0x0", |
There was a problem hiding this comment.
I guess these should really map the actual json names, rather than what we use internally
There was a problem hiding this comment.
When you run what's in the readme for that folder. But I just checked, it works fine now!
| mkDynamicTx(0, common.Address{}, params.TxGas, big.NewInt(0), big.NewInt(0)), | ||
| }, | ||
| want: "could not apply tx 0 [0xc4ab868fef0c82ae0387b742aee87907f2d0fc528fc6ea0a021459fb0fc4a4a8]: fee cap less than block base fee: address 0x71562b71999873DB5b286dF957af199Ec94617F7, feeCap: 0 baseFee: 875000000", | ||
| want: "could not apply tx 0 [0xc4ab868fef0c82ae0387b742aee87907f2d0fc528fc6ea0a021459fb0fc4a4a8]: fee cap less than block base fee: address 0x71562b71999873DB5b286dF957af199Ec94617F7, gasFeeCap: 0 baseFee: 875000000", |
There was a problem hiding this comment.
Maybe these also should use the 'public' names, not the internal
I'm kind of against that. It's important to keep the codebase consistent. |
…um#23010) * all: rename internal 1559 gas fields, add support for graphql * cmd/evm/testdata, core: use public 1559 gas names on API surfaces
3 participants
No description provided.