internal: get pending and queued transaction by address

[markya0616]

We can call Content() to get all pending and queued transactions, but the response is really large...
This pull request implements an API to filter the pending/queued transactions by an address.

[karalabe]

This seems very wasteful to retrieve all that data just to throw away most of it. I think if you wanted to get thins functionality in, we should add a PendingFrom and QueuedFrom into the txpool where we can retrieve only the data we need.

[karalabe]

Or to keep it consistent with te current API, ContentFrom

[markya0616]

@karalabe Thanks for your review. The PR is updated.

[holiman]

You re-make these later on, so these one just get overwritten

[holiman]

Looking at it a bit more closely, I think this is what Peter meant. When you call TxpoolContent, it goes down into this method:

func (pool *TxPool) Content() (map[common.Address]types.Transactions, map[common.Address]types.Transactions) {
	pool.mu.Lock()
	defer pool.mu.Unlock()

	pending := make(map[common.Address]types.Transactions)
	for addr, list := range pool.pending {
		pending[addr] = list.Flatten()
	}
	queued := make(map[common.Address]types.Transactions)
	for addr, list := range pool.queue {
		queued[addr] = list.Flatten()
	}
	return pending, queued
}

You could instead define a new method which doesn't even bother with all the addresses that aren't what you're looking for, and save a lot of work.

[markya0616]

@holiman, thanks for your review. I refined my PR based on your comments. :)

[holiman]

Looks good, thanks!
(caveat: I haven't tested it yet)

[markya0616]

@karalabe Do you have any thoughts about this PR?

[markya0616]

@karalabe Do you have any thoughts about this PR?

[karalabe]

LGTM