core: add new eip-1559 tx constraints#22970
Merged
holiman merged 5 commits intoethereum:masterfrom May 30, 2021
Merged
Conversation
holiman
approved these changes
May 30, 2021
Contributor
holiman
left a comment
There was a problem hiding this comment.
LGTM
I pushed some minor changes, reducing the bigints in buygas, and making the big number exactly on the bitlength boundary.
Contributor
Author
|
Please merge it if you have the necessary rights, I can't do that because of a random travis failure. |
Contributor
|
Odd, |
Contributor
|
I had forgotten to push some of my changes. I squashed it into the last commit, ptal @zsfelfoldi |
Contributor
|
With these new rules in place, testing on Which seems correct |
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
This PR adds the new consensus constraints of EIP-1559 transactions as specified in https://github.com/ethereum/EIPs#3594
9 tasks
This was referenced Sep 23, 2022
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new consensus constraints of EIP-1559 transactions as specified here:
ethereum/EIPs#3594
Note: the same sanity checks are performed first during tx pool validation even though the previously existing filters would filter out the same transactions. This way the same error types can be returned by the pool and by consensus.