trie/trie.go improve the delete performance#22960
Closed
Evolution404 wants to merge 1 commit intoethereum:masterfrom
Evolution404:master
Closed
trie/trie.go improve the delete performance#22960Evolution404 wants to merge 1 commit intoethereum:masterfrom Evolution404:master
Evolution404 wants to merge 1 commit intoethereum:masterfrom
Evolution404:master
Conversation
…er of non-nil entries
holiman
reviewed
May 31, 2021
Comment on lines
+418
to
+420
| if nn != nil { | ||
| pos = -2 | ||
| } else { |
Contributor
There was a problem hiding this comment.
I find this hard to intuitively verify. I think it might be easier to follow if you break here, so replace this with
if nn != nil{
// n still contains at least two values and cannot be reduced.
return true, n, nil
}As far as I can tell, that^ change should be equivalent with your change. However, looking at it, I still don't see why this is necessarily true/correct?
Contributor
Author
There was a problem hiding this comment.
if nn != nil, nn must be a child of n, which means that n itself doesn't need to be removed.
Contributor
Author
There was a problem hiding this comment.
And before the deletion, there must be another child of n.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when
nnis notnil, there is no need to check the number of non-nil entries