core/vm: implement EIP-3541 as an "extra EIP"#22768
core/vm: implement EIP-3541 as an "extra EIP"#22768chfast wants to merge 2 commits intoethereum:masterfrom
Conversation
There was a problem hiding this comment.
I'd just do evm.chainRules.IsEip3541 -- and later on change it to IsLondon or whatever
There was a problem hiding this comment.
I only refactored this. We are happy that we can create tests for Berlin+3541 for this.
There was a problem hiding this comment.
I only refactored this. We are happy that we can create tests for Berlin+3541 for this.
There was a problem hiding this comment.
Yeah, that's fine, but in the long run we should have a proper config and tie it to a forkname instead. That ^ is a bit of a hack
fjl
changed the title
|
This needs a rebase. I tried doing it myself, but the remote does not allow maintainer push |
This option is not available if a repo is not a personal one. |
| ErrWriteProtection = errors.New("write protection") | ||
| ErrReturnDataOutOfBounds = errors.New("return data out of bounds") | ||
| ErrGasUintOverflow = errors.New("gas uint64 overflow") | ||
| ErrInvalidCode = errors.New("invalid code") |
There was a problem hiding this comment.
Slightly unrelated question (not blocking this PR): EVMC has a CONTRACT_VALIDATION_FAILED error code (used as part of Ewasm 1.0). Probably we could use that error code for EOF1 validation, but should we use it already for this use case, or it makes more sense separating the error codes?
|
Done in #22809. |
3 participants
No description provided.