core, eth, ethdb, trie: simplify range proofs#22762
Merged
karalabe merged 1 commit intoethereum:masterfrom Apr 29, 2021
karalabe:snap-lower-complexity
Merged
core, eth, ethdb, trie: simplify range proofs#22762karalabe merged 1 commit intoethereum:masterfrom karalabe:snap-lower-complexity
karalabe merged 1 commit intoethereum:masterfrom
karalabe:snap-lower-complexity
Conversation
holiman
reviewed
Apr 29, 2021
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
Some nits, generally LGTM
9 tasks
9 tasks
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 9, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 4, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snap sync range prover was overly complicated because snap sync originally needed the list of trie nodes reconstructed from the proofs to avoid duplicating code. Since snap sync nowadays does not require trie nodes for large contracts and can easily reconstruct them for small ones via stacktrie, a lot of code can be deleted.
The only catch is that stack tries silently commit data to the persistent backend, so if we want to continue to properly measure the storage metrics of snap sync, we need to hook into that silent black box. This PR does so by creating a HookedBatch, which just allows us to run some code when a caller Puts an item into a wrapped batch.