deps: update uint256 to 1.2.0#22745
Conversation
|
@holiman Thanks for your lovely uint256 package, but your latest release violates the rules of semantic versioning. It introduces a breaking API change; the function signature changes from Before merging this, maybe you'd like to consider renaming the uint256 v1.2.0 release to v2.0.0? This will have the added benefit of unbreaking other projects which depend on uint256. |
|
Yes, that's true. I considered it, but the thing with major version updates is that it requires you to keep the original code intact, and copy the whole codebase to a I felt that it was a bit overkill. Yes, the API changed, but not in a 'dangerous' way (for example, like a database which changes the db on-disk format in a backwards-incompatible way), only in a small way which should be easy to fix. I didn't think that a lot of projects were using I went through the major-upgrade excercise when I upgraded the Apologies for any problems caused! |
1.2.0mainly contains some conversions, and also API-changes to make it more closely resemble abig.Int, and fixes an error inSubUint64(which is unused in our code) .