p2p/discover: handle IPv4 mapped in IPv6 addresses#22703
Merged
fjl merged 1 commit intoethereum:masterfrom Apr 23, 2021
Merged
Conversation
fjl
changed the title
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…reum#22703) When receiving PING from an IPv4 address over IPv6, the implementation sent back a IPv4-in-IPv6 address. This change makes it reflect the IPv4 address.
9 tasks
9 tasks
This was referenced Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event a local node is binded to both an IPV4 and IPV6 interface, it will treat any inbound packets from an IPV4 address as a v4 in v6 mapped address. This leads to any source IPs being denominated in that fashion. The PR carries out a check so that v4 in v6 mapped addresses are reduced to their initial form which would be a simple IPv4 address. This also reduces the number of bytes in the
ToIPfield from 16 bytes to 4 bytes in aPongpacket.