Skip to content

core: test genesis:genesisHash values (and fix YoloV3)#22559

Merged
fjl merged 2 commits intoethereum:masterfrom
etclabscore:yolov3-genesis-hash
Apr 15, 2021
Merged

core: test genesis:genesisHash values (and fix YoloV3)#22559
fjl merged 2 commits intoethereum:masterfrom
etclabscore:yolov3-genesis-hash

Conversation

@meowsbits
Copy link
Copy Markdown
Contributor

@meowsbits meowsbits commented Mar 23, 2021

Add a simple unit test checking if hardcoded
genesis hash values (in params) match with
the default genesis values.

Resolves #22560

Add a simple unit test checking if hardcoded
genesis hash values (in params) match with
the default genesis values.

Date: 2021-03-23 12:37:24-05:00
Signed-off-by: meows <b5c6@protonmail.com>
Date: 2021-03-23 12:43:58-05:00
Signed-off-by: meows <b5c6@protonmail.com>
@meowsbits meowsbits changed the title core: test genesis:genesisHash values (yolov3 fails) core: test genesis:genesisHash values (and fix YoloV3) Mar 23, 2021
@fjl fjl merged commit 3cfd0fe into ethereum:master Apr 15, 2021
@fjl
Copy link
Copy Markdown
Contributor

fjl commented Apr 15, 2021

Thanks!

@fjl fjl added this to the 1.10.3 milestone Apr 15, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
This adds simple unit test checking if the hard-coded genesis
hash values in package params match the actual genesis block hashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

params: YoloV3GenesisHash is wrong

2 participants