cmd/geth: disable snapshotter in export cmd#22388
Closed
s1na wants to merge 2 commits intoethereum:masterfrom
Closed
cmd/geth: disable snapshotter in export cmd#22388s1na wants to merge 2 commits intoethereum:masterfrom
s1na wants to merge 2 commits intoethereum:masterfrom
Conversation
s1na
changed the title
|
15 tasks
Contributor
|
This was fixed in a different way by #22407 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export command has snapshotter enabled by default even though it's not necessary. This PR disables it.
If I'm not mistaken every command that uses
MakeChainwill have it enabled by default. The 2 other cmds I'm unsure if they need snapshots arecopydbanddump(I'm guessing they do).