internal/ethapi: disable sending of non eip155 replay protected tx

[MariusVanDerWijden]

This PR prevents users from submitting transactions without EIP-155 enabled.
Replay protection is important so we should gently force our users to use it.

It changes the JSON-RPC API quite significantly, so if you see the "only replay-protected (EIP-155) transactions allowed over RPC" error, you know that you need to update your signer.

To test:

cl, sk := getRealBackend()
fakeTx := types.NewTransaction(0, common.HexToAddress(ADDR), big.NewInt(0), 21000, big.NewInt(1), nil)
noneip, err := types.SignTx(fakeTx, types.HomesteadSigner{}, sk)
if err != nil {
	panic(err)
}
if err := cl.SendTransaction(context.Background(), noneip); err != nil {
	fmt.Println(err) // Prints "only replay-protected (EIP-155) transactions allowed over RPC"
}
eip155, err := types.SignTx(fakeTx, types.NewEIP155Signer(big.NewInt(1337)), sk)
if err != nil {
	panic(err)
}
if err := cl.SendTransaction(context.Background(), eip155); err != nil {
	panic(err)
}

[karalabe]

Do we want to add a flag to disable this protection?

[holiman]

Do we want to add a flag to disable this protection?

I suggest rpc.allow-unprotected-txs which defaults to false

[holiman]

$ geth --dev --rpc.allow-unprotected-txs console 2>&1 | tail -n2
   
flag provided but not defined: -rpc.allow-unprotected-txs

You forgot to add it to the enabled flags, I think

[karalabe]

There is no reason to check if it's set or not. That's only needed if the default has some special meaning. We only care about the actual value of the flag, so pls just use cfg.UnprotectedAllowed = ctx.GlobalBool(AllowUnprotectedTxs.Name)

[MariusVanDerWijden]

Yes there is, when we simply override it here, then we will always overwrite the value we read out of the config.
See martins comments below

[MariusVanDerWijden]

@holiman Duh, I enabled it now and tested it

[holiman]

Almost, but not quite :)
With

[user@work go-ethereum]$ git diff 
diff --git a/eth/backend.go b/eth/backend.go
index d20920df0b..0c5e53b171 100644
--- a/eth/backend.go
+++ b/eth/backend.go
@@ -223,6 +223,7 @@ func New(stack *node.Node, config *ethconfig.Config) (*Ethereum, error) {
        eth.miner.SetExtra(makeExtraData(config.Miner.ExtraData))
 
        eth.APIBackend = &EthAPIBackend{stack.Config().ExtRPCEnabled(), stack.Config().UnprotectedAllowed, eth, nil}
+       log.Info("unprotected allowed", "value", eth.APIBackend.unprotectedAllowed)
        gpoParams := config.GPO
        if gpoParams.Default == nil {
                gpoParams.Default = config.Miner.GasPrice

And

[user@work go-ethereum]$ geth --rpc.allow-unprotected-txs=true --maxpeers 0 --nodiscover dumpconfig > conf.test
INFO [02-18|11:21:53.931] Maximum peer count                       ETH=0 LES=0 total=0
INFO [02-18|11:21:53.931] Smartcard socket not found, disabling    err="stat /run/pcscd/pcscd.comm: no such file or directory"
INFO [02-18|11:21:53.932] Set global gas cap                       cap=25000000

Stored to config?

[user@work go-ethereum]$ cat conf.test | grep Unpro
UnprotectedAllowed = true

Yes. However:

[user@work go-ethereum]$ geth --config conf.test --maxpeers 0 --nodiscover 
INFO [02-18|11:22:12.110] Starting Geth on Ethereum mainnet... 
...
INFO [02-18|11:22:12.300] Allocated fast sync bloom                size=1.26GiB
INFO [02-18|11:22:12.305] unprotected allowed                      value=false

[karalabe]

Why is this tied to the http flag?

[karalabe]

please type it out, transactions :P

[holiman]

Oh, that log line, I just usee it for testing, didn't mean it had to be incorporated.... But actually it might be good to have somewhere

[holiman]

LGTM

[csquan]

when I send tx,I still got error:"Cannot submit unprotected transaction".
what should I do?

[MariusVanDerWijden]

Don't use non-eip155 replay protected transactions. They are unsafe as they can be replayed on a different chain.

[csquan]

but seng tx as I usually do,usually I successsend tx. This time just to metis mannet.what should I do ? mars ***@***.***  

…

------------------ 原始邮件 ------------------ 发件人: "ethereum/go-ethereum" ***@***.***>; 发送时间: 2022年5月27日(星期五) 凌晨0:39 ***@***.***>; ***@***.******@***.***>; 主题: Re: [ethereum/go-ethereum] internal/ethapi: disable sending of non eip155 replay protected tx (#22339) Don't use non-eip155 replay protected transactions. They are unsafe as they can be replayed on a different chain. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>