Merged
Conversation
4 tasks
MariusVanDerWijden
force-pushed
the
state-test-format
branch
from
bdb3577 to
f1e6e0e
Compare
Contributor
|
On this PR, are you able to execute the tests in ethereum/tests#774 ? |
holiman
force-pushed
the
state-test-format
branch
from
f1e6e0e to
7bc462d
Compare
Contributor
|
Rebased |
Contributor
|
holiman
force-pushed
the
state-test-format
branch
from
1f458a8 to
278351b
Compare
MariusVanDerWijden
force-pushed
the
state-test-format
branch
from
278351b to
8f7dd05
Compare
MariusVanDerWijden
requested review from
gballet,
holiman,
karalabe,
rjl493456442 and
zsfelfoldi
as code owners
Member
Author
|
It passes the newest version (ethereum/tests@0966f56) of the ethereum/tests flawlessly! |
Contributor
|
Obviously this will need a rebase, and it's a bit hard to see the changes -- but did you add the new tests? If not, please add the updated tests (or maybe wait until they've been merged to master) |
Member
Author
|
Didn't add the tests yet, will do once they merge |
MariusVanDerWijden
force-pushed
the
state-test-format
branch
from
8f7dd05 to
3291e5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates marshalling and execution for the new access list format in the state tests
depends on #21502