consensus: Remove seal verification from the consensus engine interface#22274
Merged
karalabe merged 1 commit intoethereum:masterfrom Feb 5, 2021
Merged
Conversation
renaynay
pushed a commit
to renaynay/go-ethereum
that referenced
this pull request
Feb 9, 2021
renaynay
pushed a commit
to renaynay/go-ethereum
that referenced
this pull request
Feb 16, 2021
9 tasks
9 tasks
This was referenced Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VerifySealbecame unreferenced when the remote miner API was moved into the consensus engine package.For the eth2 merge, it would make my life a bit simpler not to have to care about that, since all I have to care about is disable the call to
verifySealinVerifyHeaderonce the merge block has passed.