Skip to content

core: aiming genesis when middle block is missing#22135

Merged
holiman merged 2 commits intoethereum:masterfrom
rjl493456442:fix-bc-panic
Jan 25, 2021
Merged

core: aiming genesis when middle block is missing#22135
holiman merged 2 commits intoethereum:masterfrom
rjl493456442:fix-bc-panic

Conversation

@rjl493456442
Copy link
Copy Markdown
Member

Fixes #22129

Copy link
Copy Markdown
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

Copy link
Copy Markdown

@DGKSK8LIFE DGKSK8LIFE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread core/blockchain.go Outdated
Co-authored-by: ligi <ligi@ligi.de>
@rjl493456442 rjl493456442 added this to the 1.10.0 milestone Jan 12, 2021
@holiman holiman merged commit 49cdcf5 into ethereum:master Jan 25, 2021
bulgakovk pushed a commit to bulgakovk/go-ethereum that referenced this pull request Jan 26, 2021
When a sethead/rewind finds that the targeted block is missing, it resets to genesis instead of crashing. Closes ethereum#22129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fast-synced node crushes

4 participants