cmd/geth: Graceful shutdown if disk is full by alex347 · Pull Request #22103 · ethereum/go-ethereum

alex347 · 2021-01-03T23:03:46Z

Adding warnings of low free disk space left and graceful shutdown when there is not enough space left.

Adding warnings of free disk space left and graceful shutdown when there is not enough space left.

ligi · 2021-01-03T23:08:16Z

Is this a replacement for #21884 ?

alex347 · 2021-01-03T23:28:00Z

Is this a replacement for #21884 ?

yes, this PR implements #20965 and takes into account comments from #21884

ligi · 2021-01-03T23:37:18Z

Thanks for the work on it - but I think it would be better to do the changes in the old PR then - wondering why you opened a new one. Seems you know how to push to a existing PR.

alex347 · 2021-01-03T23:45:00Z

I don't think I can modify PR if I'm not the author of it? Do you mean pushing my changes to vyrwu:handle-full-disk ?

ligi · 2021-01-03T23:49:42Z

Oh sorry - just saw that the other PR is not from you - you did everything good then.

code formatting Co-authored-by: Martin Holst Swende <martin@swende.se>

changing free disk warn level; check free disk space once in a minute

holiman · 2021-01-04T20:53:46Z

 		defer signal.Stop(sigc)
+
+		syncMode := *GlobalTextMarshaler(ctx, SyncModeFlag.Name).(*downloader.SyncMode)
+		if chainID.Int64() == 1 && syncMode != downloader.FastSync {


It's the light sync mode we want to make an exception for.

Still, I'm not 100% sure this is the best approach, I'll think about it.

holiman · 2021-01-05T09:59:26Z

Two comments from the triage:

We need to add a flag to explicitly set the limit. If it's set to 0, then the mechanism should be disabled.
Instead of using chain id / syncmode, we should default to using the limit == dirty-cache size (25% of the cache size).

holiman

This turned out pretty neat in the end, thanks for working on it!
It appears to work fine on linux, would be neat to get this tested on Windows, Darwin and/or FreeBsd too.
And potentially if the datadir is mapped via some other filesystem, like an NFS mount.

alex347 · 2021-01-06T18:48:14Z

would be neat to get this tested on Windows, Darwin and/or FreeBsd too.
And potentially if the datadir is mapped via some other filesystem, like an NFS mount.

I've tested it and it works fine on Windows, Darwin and NFS mount

ligi · 2021-01-06T19:17:36Z

Do you mind showing some proof or elaborating?

if you really want to help: test it yourself instead of asking for proof from someone that put in really good work into this feature - also not sure what kind of elaboration is needed here

Adding warnings of free disk space left and graceful shutdown when there is not enough space left. This also adds a flag datadir.minfreedisk which can be used to set the trigger for low disk space, and setting it to zero disables the check. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com>

gaia · 2021-03-03T17:39:25Z

How low is low? Is it % or MB? Is it possible to adjust this setting?

cmd/geth: monitoring free disk space to avoid db corruption

b5adbc4

Adding warnings of free disk space left and graceful shutdown when there is not enough space left.

code formatting

d6a22bf

alex347 mentioned this pull request Jan 4, 2021

Graceful shutdown if disk is full #20965

Closed