eth/downloader: removed unnecessary invalid chain error check#22052
Merged
holiman merged 1 commit intoethereum:masterfrom Dec 27, 2020
Merged
eth/downloader: removed unnecessary invalid chain error check#22052holiman merged 1 commit intoethereum:masterfrom
holiman merged 1 commit intoethereum:masterfrom
Conversation
jeongkyun-oh
requested review from
holiman,
karalabe and
rjl493456442
as code owners
jeongkyun-oh
changed the title
jeongkyun-oh
force-pushed
the
remove-unnecessary-check
branch
from
7eade38 to
3075d5f
Compare
Contributor
|
This LGTM, seems like the only possible values it can have at that point is |
holiman
approved these changes
Dec 23, 2020
Contributor
|
Thanks! |
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In downloader queue update (#21263), the invalid chain error assignment is removed.
So, the invalid chain error checking is not necessary anymore.