core: speed up header import#21967
Merged
holiman merged 4 commits intoethereum:masterfrom Jan 26, 2021
Merged
Conversation
3ba14c9 to
90be6be
Compare
holiman
commented
Dec 9, 2020
ucwong
reviewed
Dec 18, 2020
Contributor
Author
There was a problem hiding this comment.
b5aa900 to
6bce7c4
Compare
Contributor
Author
karalabe
reviewed
Jan 26, 2021
karalabe
approved these changes
Jan 26, 2021
Member
karalabe
left a comment
There was a problem hiding this comment.
Pls fix utx->unix, othewise SGTM
d06d950 to
92a53c9
Compare
9 tasks
9 tasks
This was referenced Sep 23, 2022
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is a follow up to #21471.
Charts and niceties can be found here: https://github.com/holiman/headerimport/blob/main/README.md
This PR implements the following modifications
Nowtime.Nowfor every single headerTLDR: With these changes, writing 1M headers goes down to
62sfor 1M headers, from106son (old) master, and80son PR 21471.