Skip to content

ethstats: overwrite old errors#21428

Merged
karalabe merged 1 commit intoethereum:masterfrom
holiman:ethstats_moar
Aug 7, 2020
Merged

ethstats: overwrite old errors#21428
karalabe merged 1 commit intoethereum:masterfrom
holiman:ethstats_moar

Conversation

@holiman
Copy link
Contributor

@holiman holiman commented Aug 7, 2020

Tiny change, fixes a corner-case in ethstats. If there are multiple URLs, and the first one(s) fail, but a later one works, the first error will prevail and prevent the connection from being established.

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.9.19 milestone Aug 7, 2020
@karalabe karalabe merged commit 48b484c into ethereum:master Aug 7, 2020
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 5, 2025
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 8, 2025
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Sep 13, 2025
Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants