whisper: move whisper to another repo#21371
Closed
gballet wants to merge 5 commits intoethereum:masterfrom
Closed
Conversation
holiman
reviewed
Aug 4, 2020
| github.com/golang/snappy v0.0.2-0.20200707131729-196ae77b8a26 | ||
| github.com/google/go-cmp v0.3.1 // indirect | ||
| github.com/gorilla/websocket v1.4.1-0.20190629185528-ae1634f6a989 | ||
| github.com/gorilla/websocket v1.4.1 |
Contributor
There was a problem hiding this comment.
This change is actually going from 1.4.1+ back to 1.4.1, no?
I think in general, you seem have updated the go modules in 'wildcard mode'? While that may be good (or not), I think deps-updates should be done more deliberately in a separate PR.
holiman
reviewed
Aug 4, 2020
Comment on lines
-196
to
-201
| whisperFlags = []cli.Flag{ | ||
| utils.WhisperEnabledFlag, | ||
| utils.WhisperMaxMessageSizeFlag, | ||
| utils.WhisperMinPOWFlag, | ||
| utils.WhisperRestrictConnectionBetweenLightClientsFlag, | ||
| } |
Contributor
There was a problem hiding this comment.
It might be better to leave the flags, but put them in 'DeprecatedFlags' and just issue warnings whenever any one of them is used. "The flag xxx has been deprecated; whisper has been moved to a separate repository (link)." Otherwise nodes which uses these flags will just fail to come up again after an update.
Member
Author
|
Replaced by #21487. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Whisper to its own repo.